too many changes to merge it as is.
Yeah agree, for that reason I wanted to know your opinion if you’d like to have this merged some time.
FC support dropped
Of course this can be configurable, it only depends on iscsiadm used in the iscsi_login and iscsi_logout functions.
Also I put iscsiadm -m session --rescan into rescan_scsi_bus, because without this it was not working for some reason in my environment (Ubuntu 20.04.2 LTS (Focal Fossa))
too tight to your infrastructure - for example tm/clone clones image across 3par systems
This is not entirely true. You’re right that opportunity to copy images between 3pars were added, but in case if system_ds is located in same 3par as images_ds the simple copying in one 3par will be performed, right as it was before.
If you’re talking about the fact of changing CLONE_TARGET=SELF to SYSTEM, then my bad, I didn’t write about this change in changelog. Nevertheless I believe both options can exist.
But if I understood this correct, this option must persist in oned.conf configuration file and accordingly can’t be configurable per each datastore separately.
regarding locking, looks like, you can tm/clone only one VM at a time, we can provision 100 VMs at the same time because we leverage storage system clone functionality
not exactly, locking was needed only for tm/clone and datastore/clone to support cases when image is copied between the different 3par systems. As in this case copying is performed using dd instead of using simple API calls. In case of copying in same 3par system the locking mechanism is not required.
if you want to merge your changes, it has to be all configurable
Okay. I will clarify this question with my supervisors. And if they agree to invest my time in this I will do this 
One more question: How would you like to get and review these changes: with one piece or should I devide them into many small patches?
In case of success can you help me with testing this driver with FC?
